• 0
Golias

List of potential small errors in code relating to missing private

Question

Dear Exile team,

Like @WolfkillArcadia suggested to me on Discord, I am sending to you a report on minor issues on the source code of the server side. This report was compiled using the SQF analyzer that I am developing, against the latest version of the server code. Do not assume that every warning should be dealt with, but I believe that some warnings indicate that something is not right.

To give you a specific example, in file `ExileServer_system_party_network_updateMyPartyMarkerRequest.sqf`, you have a block of the form

try {
	{...} forEach ...
} catch {
	_x call ...;
};

In the catch, I believe `_x` is always anything.

Here is the full list: [line, column]

ExileServer_object_player_createBambi.sqf
	[40,0]:warning:Local variable "_name" assigned to an outer scope (not private)
	[70,21]:warning:Local variable "_name" is not from this scope (not private)
	[82,39]:warning:Local variable "_name" is not from this scope (not private)
ExileServer_object_player_database_load.sqf
	[17,0]:warning:Local variable "_name" assigned to an outer scope (not private)
	[52,16]:warning:Local variable "_name" is not from this scope (not private)
	[59,34]:warning:Local variable "_name" is not from this scope (not private)
ExileServer_object_player_network_hasPlayerRequest.sqf
	[22,1]:warning:Local variable "_uid" assigned to an outer scope (not private)
	[27,5]:warning:Local variable "_uid" is not from this scope (not private)
	[31,47]:warning:Local variable "_uid" is not from this scope (not private)
ExileServer_system_clan_network_addPolyRequest.sqf
	[57,79]:warning:Local variable "_exception" is not from this scope (not private)
ExileServer_system_database_connect.sqf
	[14,0]:warning:Local variable "_error_locked" assigned to an outer scope (not private)
	[32,2]:warning:Local variable "_error_locked" assigned to an outer scope (not private)
	[57,6]:warning:Local variable "_error_locked" is not from this scope (not private)
ExileServer_system_event_ambientFlyOver_start.sqf
	[13,0]:warning:Local variable "_group" assigned to an outer scope (not private)
	[47,10]:warning:Local variable "_group" is not from this scope (not private)
	[49,21]:warning:Local variable "_group" is not from this scope (not private)
	[67,0]:warning:Local variable "_group" is not from this scope (not private)
	[68,0]:warning:Local variable "_group" is not from this scope (not private)
	[69,0]:warning:Local variable "_group" is not from this scope (not private)
	[70,0]:warning:Local variable "_group" is not from this scope (not private)
	[71,0]:warning:Local variable "_group" is not from this scope (not private)
	[72,12]:warning:Local variable "_group" is not from this scope (not private)
	[76,12]:warning:Local variable "_group" is not from this scope (not private)
ExileServer_system_network_event_onHandleDisconnect.sqf
	[15,0]:warning:Local variable "_uid" assigned to an outer scope (not private)
	[16,0]:warning:Local variable "_name" assigned to an outer scope (not private)
	[19,5]:warning:Local variable "_uid" is not from this scope (not private)
	[31,32]:warning:Local variable "_uid" is not from this scope (not private)
	[40,48]:warning:Local variable "_uid" is not from this scope (not private)
	[40,54]:warning:Local variable "_name" is not from this scope (not private)
	[43,35]:warning:Local variable "_name" is not from this scope (not private)
	[47,32]:warning:Local variable "_uid" is not from this scope (not private)
ExileServer_system_network_event_onPlayerConnected.sqf
	[13,0]:warning:Local variable "_uid" assigned to an outer scope (not private)
	[14,0]:warning:Local variable "_name" assigned to an outer scope (not private)
	[15,5]:warning:Local variable "_uid" is not from this scope (not private)
	[17,41]:warning:Local variable "_name" is not from this scope (not private)
	[17,48]:warning:Local variable "_uid" is not from this scope (not private)
	[18,47]:warning:Local variable "_uid" is not from this scope (not private)
	[21,38]:warning:Local variable "_uid" is not from this scope (not private)
	[21,44]:warning:Local variable "_name" is not from this scope (not private)
	[25,32]:warning:Local variable "_uid" is not from this scope (not private)
	[25,38]:warning:Local variable "_name" is not from this scope (not private)
ExileServer_system_party_network_updateMyPartyMarkerRequest.sqf
	[42,1]:warning:Local variable "_x" is not from this scope (not private)
ExileServer_system_process_preInit.sqf
	[21,0]:warning:Local variable "_MySql_connection" assigned to an outer scope (not private)
ExileServer_system_territory_database_insert.sqf
	[19,0]:warning:Local variable "_build_rights" assigned to an outer scope (not private)
	[32,1]:warning:Local variable "_build_rights" is not from this scope (not private)
ExileServer_system_territory_database_load.sqf
	[17,0]:warning:Local variable "_name" assigned to an outer scope (not private)
	[38,47]:warning:Local variable "_name" is not from this scope (not private)
ExileServer_util_fill_fillContainers.sqf
	[19,2]:warning:Local variable "_current_filled" assigned to an outer scope (not private)
	[37,25]:warning:Local variable "_current_filled" is not from this scope (not private)
	[45,6]:warning:Local variable "_current_filled" is not from this scope (not private)
	[49,6]:warning:Local variable "_current_filled" is not from this scope (not private)
	[53,6]:warning:Local variable "_current_filled" is not from this scope (not private)
ExileServer_util_getFragKiller.sqf
	[23,2]:warning:Local variable "_uid" assigned to an outer scope (not private)
2 people like this

Share this post


Link to post
Share on other sites

0 answers to this question

There have been no answers to this question yet

Advertisement

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.